Updates thesis links on duplicate report #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
** Why are these changes being introduced: * The thesis records shown on the duplicate report need editing in a way that the processing form does not support (adding author records). Because of this, linking from the duplicate report to the processing form makes less sense than linking to the admin thesis form, which does allow for linking additional authors. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/ETD-378 ** How does this address that need: * This changes the link on the duplicate report from the processing form to the administrate edit thesis form. ** Document any side effects to this change: * This is a mixing of the custom UI and the administrate UI, but I believe we already do this, and it seems more justifiable than building more custom UI elements.
JPrevost
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the links on the duplicate thesis report. They currently point to the processing form, but Mikki provided feedback that this wasn't useful in this context. A better target is the administrate UI's edit thesis form, because this form allows the staff to add more author records.
Relevant ticket(s):
https://mitlibraries.atlassian.net/browse/ETD-378
Side effects
This is a mixing of the custom UI and the administrate UI, but I believe we already do this, and it seems more justifiable than building more custom UI elements.
Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
NO